[12.x] Add queue to JobPopping#58413
Merged
taylorotwell merged 5 commits intolaravel:12.xfrom Jan 19, 2026
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
jackbayliss
changed the title
jackbayliss
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JobPopping event currently only includes the connection name, but not the queue.
Adding the queue property helps when you're running various different queues (when tracking things like frequency etc with this event) mainly helpful for loggers/metrics etc
JobPopped/JobProcessing etc allow us to access the queue via the job, ie via
getQueue()but this event doesn't give us access to the queue so this aligns them closer.I've defaulted it to null incase anyone is overriding or extending it etc - to avoid any b/c but feel free to adjust.