[12.x] Add hasMany() method to collections#58550
Merged
taylorotwell merged 2 commits intolaravel:12.xfrom Jan 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames
containsManyItems()tohasMany(), and adds callback and operator support.Background
In #58312,
containsManyItems()was added as a companion tocontainsOneItem(). Now that we havehasSole()(#58463), we should add a matchinghasMany()method.This is now more coherent:
New Method
hasMany()checks if a collection contains more than one item, with the same filter signatures ashasSole():Improvements
containsManyItems()had several issues:Collectionused a manual complex loop, instead of simply usingtake(2)->count().Collectionaccepted a callback,LazyCollectiondid not.$proxiesarray.LazyCollection::containsManyItems()had no laziness tests.hasMany()addresses all of these with a single, shared implementation in theEnumeratesValuestrait.Deprecation
containsManyItems()is now deprecated and delegates tohasMany().Laravel 13
After this is merged, and then merged into
master, we'll add this method to theEnumerableinterface, and remove thecontainsManyItems()method completely.