[12.x] Adjust docblock for formatActionForCli#58562
Merged
taylorotwell merged 1 commit intolaravel:12.xfrom Jan 30, 2026
Merged
[12.x] Adjust docblock for formatActionForCli#58562taylorotwell merged 1 commit intolaravel:12.xfrom
taylorotwell merged 1 commit intolaravel:12.xfrom
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Contributor
Author
|
This is failing due to: However, static analysis seems to pass re: https://github.com/laravel/framework/actions/runs/21530087609/job/62043587891?pr=58562 So should be good for review 🖖🏻 |
Contributor
|
Thanks for fixing—I encountered that as well 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing static analysis issues:
https://github.com/laravel/framework/actions/runs/21527588688/job/62035125987
Which I retriggered here:
https://github.com/jackbayliss/framework/actions/runs/21529548767/job/62041765393
The
formatActionForClimethod can actually be null, which is why we have?? ''framework/src/Illuminate/Foundation/Console/RouteListCommand.php
Line 406 in a16a88b