Skip to content

[12.x] Adjust docblock for formatActionForCli#58562

Merged
taylorotwell merged 1 commit intolaravel:12.xfrom
jackbayliss:adjust-docblock-type-formatActionForCli
Jan 30, 2026
Merged

[12.x] Adjust docblock for formatActionForCli#58562
taylorotwell merged 1 commit intolaravel:12.xfrom
jackbayliss:adjust-docblock-type-formatActionForCli

Conversation

@jackbayliss
Copy link
Contributor

This was causing static analysis issues:

https://github.com/laravel/framework/actions/runs/21527588688/job/62035125987

Which I retriggered here:
https://github.com/jackbayliss/framework/actions/runs/21529548767/job/62041765393

The formatActionForCli method can actually be null, which is why we have ?? ''

str_replace(' ', '', $action ?? ''),

@github-actions
Copy link

Thanks for submitting a PR!

Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@jackbayliss
Copy link
Contributor Author

This is failing due to:

Passing floats to BigNumber::of() and arithmetic methods is deprecated and will be removed in 0.15. Cast the float to string explicitly to preserve the previous behaviour.

However, static analysis seems to pass re: https://github.com/laravel/framework/actions/runs/21530087609/job/62043587891?pr=58562

So should be good for review 🖖🏻

@jackbayliss jackbayliss marked this pull request as ready for review January 30, 2026 20:49
@shaedrich
Copy link
Contributor

Thanks for fixing—I encountered that as well 👍🏻

@taylorotwell taylorotwell merged commit 7c4aed5 into laravel:12.x Jan 30, 2026
48 of 72 checks passed
@jackbayliss jackbayliss deleted the adjust-docblock-type-formatActionForCli branch January 30, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments