[13.x] Add BackedEnum support to SimpleMessage mailer method#59680
Closed
julesjanssen wants to merge 1 commit into
Closed
[13.x] Add BackedEnum support to SimpleMessage mailer method#59680julesjanssen wants to merge 1 commit into
julesjanssen wants to merge 1 commit into
Conversation
Contributor
|
If this is to match MailManager::mailer, shouldnt it be UnitEnum? 👀 |
Contributor
Author
|
Hmm. You're right, but how is that even useful? |
Contributor
|
|
Contributor
Author
|
Makes sense. Thank you. |
Member
|
I've got Enum PR fatigue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Enumsupport to themailer()method onIlluminate\Notifications\Messages\SimpleMessage(and thereforeMailMessage), matching the behavior already present inIlluminate\Mail\MailManager::mailer().This allows a dedicated mailer to be selected using an enum when composing a mail notification, instead of a hard-coded string:
Plain strings continue to work as before — the value is resolved through the
enum_value()helper.