Skip to content

[13.x] Allow Table Attribute on child to override parent#59701

Merged
taylorotwell merged 1 commit into
laravel:13.xfrom
jackbayliss:table-child-override
Apr 15, 2026
Merged

[13.x] Allow Table Attribute on child to override parent#59701
taylorotwell merged 1 commit into
laravel:13.xfrom
jackbayliss:table-child-override

Conversation

@jackbayliss

@jackbayliss jackbayliss commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Imagine you're using a package that specifies $table = xxx that you can override when you extend it.

You now want to use Laravel 13's cool attributes, but, the #[Table] attribute does not override a parents property if you're extending it.

A good example is Spatie's activity log

Where it's a class you dont control, but where you want to do:

#[Table(name: 'i_wanna_be_cool')]
class Activity extends BaseActivity
{
}

Performance should be fine, as we're only using hasProperty / getDeclaringClass, so no newInstance hit afaik

I've added plenty of tests to cover all scenarios I can think of, so no B/C

You may see a nicer way to do this, so please conduct surgery as you see fit! 🙇🏻

@github-actions

Copy link
Copy Markdown

Thanks for submitting a PR!

Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

explicit

readability pls

dont add a space

im only human... after all

test up

Update DatabaseEloquentModelAttributesTest.php
@jackbayliss
jackbayliss force-pushed the table-child-override branch from 05f0373 to 8c5ce06 Compare April 15, 2026 10:33
@jackbayliss
jackbayliss marked this pull request as ready for review April 15, 2026 10:42
@taylorotwell
taylorotwell merged commit 99f4ce2 into laravel:13.x Apr 15, 2026
52 checks passed
jonagoldman pushed a commit to deplox/laravel-framework that referenced this pull request Apr 30, 2026
explicit

readability pls

dont add a space

im only human... after all

test up

Update DatabaseEloquentModelAttributesTest.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants