[13.x] Allow Table Attribute on child to override parent#59701
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
explicit readability pls dont add a space im only human... after all test up Update DatabaseEloquentModelAttributesTest.php
jackbayliss
force-pushed
the
table-child-override
branch
from
April 15, 2026 10:33
05f0373 to
8c5ce06
Compare
jackbayliss
marked this pull request as ready for review
April 15, 2026 10:42
jonagoldman
pushed a commit
to deplox/laravel-framework
that referenced
this pull request
Apr 30, 2026
explicit readability pls dont add a space im only human... after all test up Update DatabaseEloquentModelAttributesTest.php
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imagine you're using a package that specifies
$table = xxxthat you can override when you extend it.You now want to use Laravel 13's cool attributes, but, the
#[Table]attribute does not override a parents property if you're extending it.A good example is Spatie's activity log
Where it's a class you dont control, but where you want to do:
Performance should be fine, as we're only using hasProperty / getDeclaringClass, so no newInstance hit afaik
I've added plenty of tests to cover all scenarios I can think of, so no B/C
You may see a nicer way to do this, so please conduct surgery as you see fit! 🙇🏻