[13.x] Allow array of pivot arrays to be passed to hasAttached#59723
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
jackbayliss
force-pushed
the
hasAttached-dx
branch
from
April 16, 2026 10:00
4278ecc to
aef66a6
Compare
jackbayliss
marked this pull request as ready for review
April 16, 2026 10:05
jonagoldman
pushed a commit
to deplox/laravel-framework
that referenced
this pull request
Apr 30, 2026
…el#59723) * 13.x-allow-has-attached-to-pass-arrays improve * Update Factory.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Morning Taylor!
I am a real human who typed this with my hands, maybe a bit of copy & paste!
I'll be at Laravel Live UK in case someone wants to verify 😃
I see a lot of:
Or we reach for Sequence explicitly:
This PR becomes the below, and is very useful when you need different pivot values:
No B/C afaik just a bit of added DX imo.
It uses
sequenceinternally, so no big maintenance burden... and is the similar to the has{Relation} magic methods we did here : #59343