[13.x] Fix flaky QueueWorkerTest by freezing time before computing retryUntil#59727
Merged
Merged
Conversation
jonagoldman
pushed a commit
to deplox/laravel-framework
that referenced
this pull request
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
QueueWorkerTest::testJobIsNotReleasedIfItHasExpiredintermittently fails on CI (observed on Windows runners):Root Cause
The test computes
retryUntiland the frozen test time from two separateCarbon::now()calls against the real wall clock (nosetTestNowis active yet):If a real-time second boundary passes between these two lines (more likely on slow CI), the frozen
nowends up 1 second ahead ofretryUntil. This causesmarkJobAsFailedIfAlreadyExceedsMaxAttemptsto see the job as already expired (now > retryUntil) and throwMaxAttemptsExceededExceptionbefore the job fires, instead of letting the job run, throwRuntimeException, and then fail viamarkJobAsFailedIfWillExceedMaxAttempts.Fix
Freeze time with
Carbon::setTestNow()before computingretryUntil, so both timestamps derive from the same deterministic base:This eliminates the real-time race entirely. The frozen
nowequalsretryUntil, so the<=check inmarkJobAsFailedIfAlreadyExceedsMaxAttemptspasses (returns early), the job fires normally, and the test exercises its intended path.1 file changed, 4 insertions, 4 deletions.