Fixes for Windows local PHP environment(s)#486
Closed
shanto wants to merge 5 commits intolaravel:mainfrom
Closed
Conversation
Support for Docker based PHP environment configurable with config keys:
{
"Laravel.dockerService": "php", // from `docker compose config --services`
"Laravel.dockerBase": "/app", // from `docker compose exec {dockerService} pwd`
}
This plugin does not auto boot Docker container(s) although it can be implemented in later revisions. For now, ensure that Docker container is running with configured dockerService name and dockerBase path as working directory before attempting to use the plugin with Docker support.
…cted string constant echo...
Contributor
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of my previous commits for Docker Environment (#483), these commits fix some of remaining issues with running the Laravel VS Code extension directly on top of Windows.
In particular, f3461be fixes the attempt to execute ./vendor/bin/pint by the IDE integrated formatter. When on Windows, it is properly prefixed by the active PHP command derived from the detected php Environment.
83e413c fixes
Unexpected string constant echo...on execution ofphp -r 'echo PHP_BINARY;'when detecting local php on Windows. Using double quotes fixes that.