CI: Remove explicit linting job and use precommit.ci instead#144
Merged
Conversation
Member
|
The ReadTheDocs failure is due to a Poetry regression in v2.1.0, released this morning. In my branch I pinned the poetry version in |
Member
|
And it looks like our |
Contributor
Author
|
Thanks! Pushed a new commit with those fixes. |
Member
|
pre-commit.ci run |
medley56
approved these changes
Feb 16, 2025
medley56
reviewed
Feb 16, 2025
Co-authored-by: Gavin Medley <7018964+medley56@users.noreply.github.com>
medley56
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current merge to main failed because it ran "no commit to a branch named main". I enabled pre-commit.ci service so that will do the linting checks for us now as a separate action. (we could remove that check to fix this too)