Skip to content

chore: add explicit permissions to release-please workflow #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kinyoklion merged 1 commit into from
Mar 31, 2026
Merged

chore: add explicit permissions to release-please workflow #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ on:
jobs:
release-please:
runs-on: ubuntu-latest
permissions:
contents: write
pull-requests: write
Copy link
Copy Markdown

@cursor cursor bot Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing issues: write permission for release-please label creation

High Severity

The new explicit permissions block is missing issues: write, which release-please-action v4.4.0 requires to create labels on pull requests when using secrets.GITHUB_TOKEN. Before this change, the job inherited default token permissions (which likely included issues: write). Adding an explicit permissions block restricts the token to only the listed permissions plus metadata: read, so issues: write is now effectively revoked. This can cause the action to fail with "You do not have permission to create labels on this repository," and without proper labels, subsequent release triggers may also break.

Fix in Cursor Fix in Web

Copy link
Copy Markdown
Member Author

@kinyoklion kinyoklion Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Irrelevant when the label has already been created.


outputs:
package-sdk-common-released: ${{ steps.release.outputs['lib/shared/common--release_created'] }}
Expand Down
Loading