This repository was archived by the owner on Sep 13, 2023. It is now read-only.
PR for issue #71 (Feature request)#74
Merged
lauthieb merged 7 commits intolauthieb:masterfrom Jun 24, 2019
Merged
Conversation
Owner
|
Hello @marvpaul , thanks a lot for your PR! |
Owner
|
Thanks a lot @marvpaul for this great PR. |
Andrei0872
pushed a commit
to Andrei0872/code-notes
that referenced
this pull request
Oct 9, 2019
* Added functionality whichs saves the notes to file system as well * Added timestamp to folder name to allow duplicated code note tiltes in filesystem * Added first tests for note creation including check if note exists in filesystem * Made some simplifications regarding file system management wih help of fs-extra * Added tests * Changed dependency version * Changed fs extra version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to implement the suggested feature from issue 71 and added some tests.