Skip to content

[Site] Fixed docs section padding#121

Merged
vinayaksh42 merged 2 commits intolayer5io:masterfrom
NikhilSharma03:docs_feature_section_padding
May 31, 2021
Merged

[Site] Fixed docs section padding#121
vinayaksh42 merged 2 commits intolayer5io:masterfrom
NikhilSharma03:docs_feature_section_padding

Conversation

@NikhilSharma03
Copy link
Copy Markdown
Member

Signed-off-by: Nikhil nikhilsharmamusic2000@gmail.com

Description

  • There was an issue with section padding on the docs page.

Before

Old

  • Added padding around the links

After Changes

New

Notes for Reviewers
Let me know if we can make any other changes. Thank you.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Nikhil <nikhilsharmamusic2000@gmail.com>
@NikhilSharma03 NikhilSharma03 changed the title fixed docs section padding [Site] Fixed docs section padding May 29, 2021
Comment thread docs/pages/docs.html Outdated
</button>
</h2>
<div id="flush-collapse{{docs.number}}" class="accordion-collapse collapse" aria-labelledby="flush-heading{{docs.number}}" data-bs-parent="#accordionFlushExample">
<div id="flush-collapse{{docs.number}}" class="accordion-collapse collapse" style="padding: 15px;" aria-labelledby="flush-heading{{docs.number}}" data-bs-parent="#accordionFlushExample">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid using inline styling as it gets a little difficult to track various different CSS changes. Instead, do all the styling changes in the designated folder.

@leecalcote
Copy link
Copy Markdown
Member

Ignoring issue of inline style, the effect is certainly an improvement. Nice work, @NikhilSharma03.

Signed-off-by: Nikhil <nikhilsharmamusic2000@gmail.com>
@NikhilSharma03
Copy link
Copy Markdown
Member Author

Thank you @leecalcote and @vinayaksh42 .Can you please review the changes?

@netlify
Copy link
Copy Markdown

netlify bot commented May 31, 2021

✔️ Website preview ready!

🔨 Explore the source changes: 3412f5f

🔍 Inspect the deploy log: https://app.netlify.com/sites/getnighthawk/deploys/60b4d407f6822500088e8e04

😎 Browse the preview: https://deploy-preview-121--getnighthawk.netlify.app

Copy link
Copy Markdown
Member

@JubayerJoy JubayerJoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@vinayaksh42
Copy link
Copy Markdown
Member

Great work! @NikhilSharma03

@vinayaksh42 vinayaksh42 merged commit 600e41a into layer5io:master May 31, 2021
@NikhilSharma03
Copy link
Copy Markdown
Member Author

Thank you @vinayaksh42

@NikhilSharma03 NikhilSharma03 deleted the docs_feature_section_padding branch June 1, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants