Skip to content

[Site] Fixed Features Page SI Footer#155

Merged
vinayaksh42 merged 2 commits intolayer5io:masterfrom
NikhilSharma03:features_footer
Aug 9, 2021
Merged

[Site] Fixed Features Page SI Footer#155
vinayaksh42 merged 2 commits intolayer5io:masterfrom
NikhilSharma03:features_footer

Conversation

@NikhilSharma03
Copy link
Copy Markdown
Member

Signed-off-by: Nikhil Sharma nikhilsharmamusic2000@gmail.com

Description

  • There is an issue in the footer on the features page as the social icons are not properly aligned

Screenshots

Screenshot from 2021-08-05 17-28-17

Screenshot from 2021-08-05 17-28-25

After Changes

  • Fixed the alignment of the social icons

Screenshots

Screenshot from 2021-08-05 17-27-46

Screenshot from 2021-08-05 17-27-39

Notes for Reviewers

  • Let me know if there are any other changes we can make.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Nikhil Sharma <nikhilsharmamusic2000@gmail.com>
@netlify
Copy link
Copy Markdown

netlify bot commented Aug 5, 2021

✔️ Website preview ready!

🔨 Explore the source changes: 258eb92

🔍 Inspect the deploy log: https://app.netlify.com/sites/getnighthawk/deploys/610cdce777252400071eec5f

😎 Browse the preview: https://deploy-preview-155--getnighthawk.netlify.app

@NikhilSharma03
Copy link
Copy Markdown
Member Author

I think we can update the features page as well.

@vinayaksh42
Copy link
Copy Markdown
Member

@NikhilSharma03 good catch on this bug in footer for Features page. Looks good to me

I think we can update the features page as well.

Yes, the links on Features page lead back to getnighthawk itself, we should add real links if possible.

@vinayaksh42
Copy link
Copy Markdown
Member

The current deployed version of getnighthawk:
opera_cktnD3jRFn
After changes:
opera_5afZqBzd7h

@NikhilSharma03 kindly check what's causing the size increase of header.

Signed-off-by: Nikhil Sharma <nikhilsharmamusic2000@gmail.com>
@NikhilSharma03
Copy link
Copy Markdown
Member Author

@vinayaksh42 Can you please review? If this is correct, let me know. I will start with fixing features page.

@vinayaksh42
Copy link
Copy Markdown
Member

@vinayaksh42 Can you please review? If this is correct, let me know. I will start with fixing features page.

LGTM! Do you want to merge this PR and work on the features page in a different Pull request or add commits to the current PR?
@NikhilSharma03

@NikhilSharma03
Copy link
Copy Markdown
Member Author

@vinayaksh42 Can you please review? If this is correct, let me know. I will start with fixing features page.

LGTM! Do you want to merge this PR and work on the features page in a different Pull request or add commits to the current PR?
@NikhilSharma03

Yes, we can merge this PR. I was thinking of making a seperate PR for features page.

@vinayaksh42 vinayaksh42 merged commit bc99690 into layer5io:master Aug 9, 2021
@NikhilSharma03 NikhilSharma03 deleted the features_footer branch August 10, 2021 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants