Skip to content

Add Nighthawk docs#181

Merged
leecalcote merged 7 commits intolayer5io:masterfrom
pottekkat:add-docs/navendu-pottekkat
Sep 23, 2021
Merged

Add Nighthawk docs#181
leecalcote merged 7 commits intolayer5io:masterfrom
pottekkat:add-docs/navendu-pottekkat

Conversation

@pottekkat
Copy link
Copy Markdown
Contributor

@pottekkat pottekkat commented Sep 23, 2021 •
edited
Loading

Signed-off-by: Navendu Pottekkat navendupottekkat@gmail.com

Description

This PR adds docs for using Nighthawk, Using GetNighthawk APIs and using Nighthawk with Meshery and SMP to run performance benchmarks.

  • Yes, I signed my commits.

@pottekkat
add Nighthawk build and usage docs
77ef492 
Signed-off-by: Navendu Pottekkat <navendupottekkat@gmail.com>
@pottekkat pottekkat added area/docs Improvements or additions to documentation pr/draft WIP/Draft pull request labels Sep 23, 2021
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 23, 2021 •
edited
Loading

✔️ Website preview ready!

🔨 Explore the source changes: 981efd6

🔍 Inspect the deploy log: https://app.netlify.com/sites/getnighthawk/deploys/614ca630ad62390008d63b8c

😎 Browse the preview: https://deploy-preview-181--getnighthawk.netlify.app

@warunicorn19
Copy link
Copy Markdown
Member

warunicorn19 commented Sep 23, 2021

@Amino19 label commenter workflow is failing.

@aminoxix aminoxix mentioned this pull request Sep 23, 2021
Merged
1 task
@warunicorn19 warunicorn19 added area/docs Improvements or additions to documentation pr/draft WIP/Draft pull request and removed area/docs Improvements or additions to documentation pr/draft WIP/Draft pull request labels Sep 23, 2021
@pottekkat
add performance testing guide with mesheryctl
f4cb940 
Signed-off-by: Navendu Pottekkat <navendupottekkat@gmail.com>
@pottekkat pottekkat marked this pull request as ready for review September 23, 2021 13:17
@pottekkat pottekkat changed the title [Draft] Add Nighthawk docs Add Nighthawk docs Sep 23, 2021
@pottekkat pottekkat requested review from DelusionalOptimist, leecalcote and vinayaksh42 and removed request for leecalcote September 23, 2021 13:18
@pottekkat
Copy link
Copy Markdown
Contributor Author

pottekkat commented Sep 23, 2021

Updated this page: https://deploy-preview-181--getnighthawk.netlify.app/docs

Will add more docs as we update Performance Management docs in Meshery

@leecalcote
Copy link
Copy Markdown
Member

leecalcote commented Sep 23, 2021

@Amino19 label commenter workflow is failing.

I went ahead and fixed this workflow.

@leecalcote leecalcote added area/docs Improvements or additions to documentation and removed area/docs Improvements or additions to documentation labels Sep 23, 2021
leecalcote
leecalcote reviewed Sep 23, 2021
View reviewed changes
docs/collections/_docs/building-nighthawk.md Outdated
bazel build -c opt //:nighthawk
```

# Using the Nighthawk CLI
Copy link
Copy Markdown
Member

@leecalcote leecalcote Sep 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this section out of the building-nighthawk page into a new page.

docs/collections/_docs/performance-benchmarking.md
- http://localhost:2323
duration: "15s"
```

Copy link
Copy Markdown
Member

@leecalcote leecalcote Sep 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need example of mesheryctl perf apply -f here.

@pottekkat
Copy link
Copy Markdown
Contributor Author

pottekkat commented Sep 23, 2021

@leecalcote Made the suggested changes. Good to merge?

@leecalcote leecalcote merged commit dabdc5f into layer5io:master Sep 23, 2021
@pottekkat pottekkat deleted the add-docs/navendu-pottekkat branch September 25, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leecalcote leecalcote leecalcote approved these changes

@vinayaksh42 vinayaksh42 Awaiting requested review from vinayaksh42

@DelusionalOptimist DelusionalOptimist Awaiting requested review from DelusionalOptimist

Assignees

No one assigned

Labels

area/docs Improvements or additions to documentation pr/draft WIP/Draft pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pottekkat @warunicorn19 @leecalcote