Skip to content

Update Docs Content Box CSS#184

Merged
warunicorn19 merged 2 commits intolayer5io:masterfrom
toth2000:toth2000/update_css
Oct 1, 2021
Merged

Update Docs Content Box CSS#184
warunicorn19 merged 2 commits intolayer5io:masterfrom
toth2000:toth2000/update_css

Conversation

@toth2000
Copy link
Copy Markdown
Member

Signed-off-by: Tothagata tothagata.bhattacharjee@gmail.com

Description
Added min-height=100vh for the content-box.

This PR fixes #183

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Tothagata <tothagata.bhattacharjee@gmail.com>
@welcome
Copy link
Copy Markdown

welcome bot commented Sep 23, 2021

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 23, 2021

✔️ Website preview ready!

🔨 Explore the source changes: 50d5d19

🔍 Inspect the deploy log: https://app.netlify.com/sites/getnighthawk/deploys/614d8c9ef1d159000704eda7

😎 Browse the preview: https://deploy-preview-184--getnighthawk.netlify.app

@vinayaksh42
Copy link
Copy Markdown
Member

Opera Snapshot_2021-09-24_094954_deploy-preview-184--getnighthawk netlify app
@toth2000 The home docs page still has the footer a bit above the bottom

Signed-off-by: Tothagata <tothagata.bhattacharjee@gmail.com>
@toth2000
Copy link
Copy Markdown
Member Author

toth2000 commented Sep 24, 2021

@vinayaksh42 Yes you are right, I have made a new commit that fix the above issue.

@warunicorn19 warunicorn19 added the hacktoberfest Happy contributing! label Oct 1, 2021
Copy link
Copy Markdown
Member

@warunicorn19 warunicorn19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🎉, Thanks @toth2000

@warunicorn19 warunicorn19 merged commit c0dd289 into layer5io:master Oct 1, 2021
@welcome
Copy link
Copy Markdown

welcome bot commented Oct 1, 2021

Thanks for your contribution to the Layer5 community! 🎉

Congrats!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ux hacktoberfest Happy contributing!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use fixed footer

4 participants