Conversation
Signed-off-by: anirudh-bukka <anirudh.bukka@gmail.com>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
|
✔️ Website preview ready! 🔨 Explore the source changes: 1f6dd22 🔍 Inspect the deploy log: https://app.netlify.com/sites/getnighthawk/deploys/61ebac81fc78310007453a60 😎 Browse the preview: https://deploy-preview-240--getnighthawk.netlify.app |
Abhijay007
left a comment
There was a problem hiding this comment.
@anirudh-bukka great work, it looks good for mobile view, just do the same changes for tab view as well ( max-width: 768px) and in that screen size try to shift nav icon bit towards right
you can also take reference from this article if you want to read more about media queries: https://www.geeksforgeeks.org/how-to-target-desktop-tablet-and-mobile-using-media-query/
On it |
Signed-off-by: anirudh-bukka <anirudh.bukka@gmail.com>
Abhijay007
left a comment
There was a problem hiding this comment.
LGTM 👍 , great work @anirudh-bukka
YashKamboj
left a comment
There was a problem hiding this comment.
@anirudh-bukka Good Work!!! just one small thing , i the "menu" written after the icon is removed ,so if you bring that back would be great .
Thanks @YashKamboj , But I felt, having the word 'menu' would make the navbar cluttered and congested. What do you say? |
Thanks @Abhijay007 ! |
I guess it will look great even without menu written |
|
Might be better toh have just the nighthawk logo in smaller views than the text logo. What do you think @debo19 |
|
@anirudh-bukka @YashKamboj @warunicorn19 The UI/UX Convention is not to have a title saying |
|
@adithyaakrishna the title |
|
My bad xD, I didnt see that :( |
@warunicorn19 It might look too empty though.🤔 I think this looks fine. |
Thanks @Abhijay007 for helping me in all the set-up and pushing my first pr! |


Signed-off-by: anirudh-bukka anirudh.bukka@gmail.com
Description
This PR fixes #189
Notes for Reviewers
Added hover effects and corrected the position of the drop down menu list from the hamburger button.
Signed commits