Added Star Meshery Repository button#319
Conversation
Signed-off-by: Ved Pahune <vedpahune@Veds-MacBook-Air.local>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
✅ Website preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Ved Pahune <vedpahune@Veds-MacBook-Air.local>
Signed-off-by: Ved Pahune <vedpahune@Veds-MacBook-Air.local>
docs/index.html
Outdated
| <div class="star-meshery"><a class="star-meshery-button" href="https://github.com/meshery/meshery" target="_blank" | ||
| "> ⭐️ Star Meshery Repository </a> | ||
| </div> |
There was a problem hiding this comment.
@vednp Thanks for the PR, let's not create a button like this.
Please refer to the https://meshery.io/ site, we need to replicate it.
There was a problem hiding this comment.
Sure, Is the position correct or should I add it in the hero section like in meshery's website?
Signed-off-by: Ved Pahune <vedpahune@Veds-MacBook-Air.local>
Signed-off-by: Ved Pahune <vedpahune@Veds-MacBook-Air.local>
|
@leecalcote @Chadha93 @Shivam-AfA can you all review this? |
|
Having the Meshery repo star button and count is great. We also need one for Nighthawk, though, too, which should point to this repo (the one that we're commenting on right now), @Chadha93 |
|
@leecalcote Should I work on it? Btw we have a link directing to this repo on the top right corner but it's not visible on mobile view so we can also add a hamburger menu for lesser screen dimensions. Your opinions? |
|
@vednp You can proceed with Lee's suggestion. |
|
@Chadha93 please draw this to a close. |
|
Thanks! |
|
Thanks for your contribution to the Layer5 community! 🎉
|
4 participants
Description
This PR fixes #299 Added a button on the homepage under the Nighthawk and Meshery section to redirect the user to the Meshery Repository
Notes for Reviewers
Signed commits