Navbar/Togglebar availability issue resolved#358
Merged
MUzairS15 merged 2 commits intolayer5io:masterfrom Jun 6, 2024
Merged
Conversation
Signed-off-by: Muhammad Moinuddin <moinuddinilyas786@gmail.com>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
✅ Website preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@Muhammed-Moinuddin Let's discuss this on Websites's call on Monday. Adding this as an agenda item into the meeting minutes. |
MUzairS15
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
On running this repo on local host I faced:
I searched the issue and updated library named : liquid by running command
bundle update liquidafter which I was successfully able to run it locally:Which automatically resolved Navbar/Togglebar availability issue, see attached SS for reference.
So the issue was with the library, and after updating it, the issue is resolved.
This PR fixes #357
Notes for Reviewers
Signed commits