perf: replace global task_finished_cv with per-task waiter notifications#13191
Draft
Kha wants to merge 1 commit intoleanprover:masterfrom
Draft
perf: replace global task_finished_cv with per-task waiter notifications#13191Kha wants to merge 1 commit intoleanprover:masterfrom
Kha wants to merge 1 commit intoleanprover:masterfrom
Conversation
Instead of a single condition_variable that wakes all waiters on every task completion (thundering herd), use a per-task waiter map. task_get and wait_any register a stack-local CV for the specific task(s) they care about, and resolve_core only notifies those waiters.
Member
Author
|
!bench |
|
Benchmark results for 126d4c7 against 4786e08 are in. Significant changes detected! @Kha
Small changes (41✅, 3🟥) Too many entries to display here. View the full report on radar instead. |
github-actions
bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Mar 30, 2026
github-actions
bot
added
the
mathlib4-nightly-available
mathlib-nightly-testing bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Mar 30, 2026
Member
Author
|
!bench mathlib |
|
Benchmark results for leanprover-community/mathlib4-nightly-testing@8e592bb against leanprover-community/mathlib4-nightly-testing@f80b5e4 are in. Significant changes detected! @Kha Warning These warnings may indicate that the benchmark results are not directly comparable, for example due to changes in the runner configuration or hardware.
No significant changes detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of a single condition_variable that wakes all waiters on every task completion (thundering herd), use a per-task waiter map. task_get and wait_any register a stack-local CV for the specific task(s) they care about, and resolve_core only notifies those waiters.