Open
Conversation
This was referenced Feb 3, 2026
Closed
Julian
reviewed
Feb 3, 2026
| recs.forM parseRecInfo | ||
|
|
||
| def parseItem (line : String) : M Unit := do | ||
| let obj ← parseJsonObj line |
There was a problem hiding this comment.
Since I had the same big if statement show up in my parser -- would it be helpful to document what order to micro-optimize the branches in somewhere based on frequency of what appears in the wild (e.g. I assume app belongs way higher).
(Obviously not highly relevant to this PR itself).
Author
There was a problem hiding this comment.
I'd be somewhat surprised if that makes a measurable difference, but feel free to gather that data from a mathlib dump and put it somewhere (maybe a comment at the bottom of the format description)
Co-authored-by: Julian Berman <[email protected]>
Co-authored-by: Henrik Böving <[email protected]>
Julian
added a commit
to Julian/rpylean
that referenced
this pull request
Feb 3, 2026
(In particular, mutual defs and theorems don't exist.) Refs: leanprover/lean4export#17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a parser for the lean4export format. It is based on #12 and the latest format iteration from #16.