Skip to content

Spinner component page#108

Merged
mwarman merged 3 commits intomainfrom
86-spinner-component-page
Mar 20, 2025
Merged

Spinner component page#108
mwarman merged 3 commits intomainfrom
86-spinner-component-page

Conversation

@mwarman
Copy link
Copy Markdown
Member

@mwarman mwarman commented Mar 20, 2025

📢 Instructions

  • Begin with a DRAFT pull request.
  • Follow italicized instructions to add detail to assist the reviewers.
  • After completing all checklist items, change the pull request to READY.

🔧 Change Summary

Describe the changes included in this pull request. Link to the associated GitHub issue(s).

  • fixes Spinner component page #86
  • Renamed LoaderSpinner to Spinner.
  • Added the Spinner.Text component for the optional text associated with a Spinner.
  • Added examples for the Spinner component.

📝 Checklist

Pull request authors must complete the following tasks before marking the PR as ready to review.

  • Complete a self-review of changes
  • Unit tests have been created or updated
  • The code is free of [new] lint errors and warnings
  • Update storybook stories as needed
  • Update project documentation as needed, README, JSDoc, etc.

🧪 Steps to Test

Describe the process to test the changes in this pull request.

Note: Also regression test the app to ensure that the spinners are displayed without any problem. This is namely on the SignOut page and when imports are lazily loaded.

  1. Go to the Components page.
  2. Click on the "Spinner" item in the left-side navigation.
  3. Review the content of the spinner examples page.

🔗 Additional Information

Optionally, provide additional details, screenshots, or URLs that may assist the reviewer.

  • [...]

@mwarman mwarman self-assigned this Mar 20, 2025
@mwarman mwarman linked an issue Mar 20, 2025 that may be closed by this pull request
@mwarman mwarman marked this pull request as ready for review March 20, 2025 11:57
@mwarman mwarman merged commit 14147dc into main Mar 20, 2025
5 checks passed
@mwarman mwarman deleted the 86-spinner-component-page branch March 20, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spinner component page

1 participant