Allows users to change language when not signed-in. thus, implementing proper language redirection as in Kolibri#3721
Merged
bjester merged 7 commits intolearningequality:unstablefrom Nov 2, 2022
Conversation
ozer550
changed the title
ozer550
changed the title
bjester
reviewed
Oct 11, 2022
Member
bjester
left a comment
bjester
left a comment
There was a problem hiding this comment.
In my testing, when I'm on the sign-in page and I change the language, the page refreshes again after reloading. It seems related to the service worker, and I think it must be the pwa/manifest.json causing it because it loads the language.
bjester
approved these changes
Oct 21, 2022
Member
bjester
left a comment
bjester
left a comment
There was a problem hiding this comment.
Looks good to me-- one comment about adding/updating the doc string
| @@ -353,42 +352,54 @@ def set_language(request): | |||
| """ | |||
Member
There was a problem hiding this comment.
Could you add/replace the doc string here noting where this code came from and what you changed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Following Pr adds the functionality to the change language while viewing the public resources page or any other pages when not being signed in. It also implements proper redirection according to session and cookie data as in Kolibri.
closes #3150
Description of the change(s) you made
Manual verification steps performed
Screenshots (if applicable)
Before:
After:
Does this introduce any tech-debt items?
Reviewer guidance
How can a reviewer test these changes?
References
The set_language function is refactored from here
Contributor's Checklist
PR process:
Testing:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)