Updates nested folder order in breadcrumb#4003
Merged
LianaHarris360 merged 1 commit intolearningequality:unstablefrom Mar 28, 2023
Merged
Updates nested folder order in breadcrumb#4003LianaHarris360 merged 1 commit intolearningequality:unstablefrom
LianaHarris360 merged 1 commit intolearningequality:unstablefrom
Conversation
thanksameeelian
approved these changes
Mar 28, 2023
| id: ancestor.id, | ||
| to: this.treeLink({ nodeId: ancestor.id }), | ||
| title: ancestor.title, | ||
| title: ancestor.parent ? ancestor.title : this.currentChannel.name, |
There was a problem hiding this comment.
i think this is a really clever solution! looks good to me!
akolson
approved these changes
Mar 28, 2023
Member
akolson
left a comment
There was a problem hiding this comment.
LGTM! Thanks @LianaHarris360. This should be merged subject to manual QA checks. cc @radinamatic
Member
|
QA team will proceed with testing as soon as the PR is merged in the |
Member
|
Hi @LianaHarris360 and @radinamatic, I was able to identify the following issues which I have reported separately: #4006 and #4007 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Updates order of nested folders within breadcrumbs.
Manual verification steps performed
Screenshots (if applicable)
Before
After
References
Closes #3842
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)