Update aggregate counts when adding, updating, copying, or moving nodes#4113
Merged
rtibbles merged 5 commits intolearningequality:hotfixesfrom Jun 16, 2023
Merged
Conversation
rtibbles
reviewed
Jun 8, 2023
Member
rtibbles
left a comment
There was a problem hiding this comment.
Changes make sense to me, and the Stream/Dispatcher pattern is very easy to follow and reason about.
Noticed one thing that we should open a follow up issue for, and one other question about a possible edge case, which we may also be able to punt on.
contentcuration/contentcuration/frontend/shared/data/applyRemoteChanges.js
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/data/serverSync.js
Outdated
Show resolved
Hide resolved
8bed755 to
ac6240e
Compare
7a845c6 to
fd90b26
Compare
rtibbles
approved these changes
Jun 16, 2023
Member
|
Hi @bjester - no issues observed while manually testing this one. I did test various scenarios for this one and I can confirm that the resource count when adding, updating, copying or moving nodes is correct. |
Member
Author
|
Woohoo! Great news @pcenov 😅 |
This was referenced Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes: #3733
Summary
Description of the change(s) you made
Adds logic that increments and decrements the
total_count,resource_count, andcoach_countwhen adding, updating, copying or moving nodes. The code processes change events, either caused by writes to indexedDB or changes from other users, and uses that information to update the ancestor node counts accordinglyManual verification steps performed
Folder A, then aFolder Binside of that, andFolder Cinside ofBFolder CMy ChannelspageFolder AFolder CFolder Cas coach contentFolder CDoes this introduce any tech-debt items?
Deleting a node does not require any of this logic, since we move nodes to the trash tree before deleting them, but it does introduce some inconsistencies.
References
Fixes #3508
Fixes #2548
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)