Add fields language, provider, aggregator, role_visibility to sync op #5590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjester
changed the title
bjester
reviewed
Dec 18, 2025
| source_node_id=contentnode.node_id | ||
| ) | ||
|
|
||
| self.assertIsNotNone(target_child) |
Member
There was a problem hiding this comment.
Dead code-- Django's get() should throw ContentNode.DoesNotExist if not found. This is repeated in each test.
Member
Author
There was a problem hiding this comment.
Seems like this was copied from some other tests in this test case, so I've cleaned it up in those too.
Add missing fields to resource details sync operation: - language: ContentNode language field - provider: Provider organization field - aggregator: Aggregator organization field - role_visibility: Visible to field (learner/coach) These fields were not being synced when users selected the "Resource details" checkbox during sync operations. They are now included in the sync_resource_details field list. Also add comprehensive unit tests to verify: - Each field syncs correctly when sync_resource_details=True - All four fields sync together - Fields do not sync when sync_resource_details=False Fixes #4930
rtibbles
force-pushed
the
claude/issue-4930-plan-01HLt4SubotNV5ebAegz2jUa
branch
from
da78d2d to
f05c8e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add missing fields to resource details sync operation:
These fields were not being synced when users selected the "Resource details" checkbox during sync operations. They are now included in the sync_resource_details field list.
Also add comprehensive unit tests to verify:
References
Fixes #4930
Reviewer guidance
🤖 This was created by Claude Code. @rtibbles then reviewed the generated output, and did iterative rounds of updates before making it ready for review 🤖
I have run the tests locally and confirmed they test what is required. Fix itself is very straightforward, simply adding the fields that had not previously been listed!