Skip to content

update numAxisSplits to throw error instead of infinite loop #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fastfrwrd wants to merge 1 commit into from
Closed

update numAxisSplits to throw error instead of infinite loop #1117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/opts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,6 +599,12 @@ export function numAxisSplits(self, axisIdx, scaleMin, scaleMax, foundIncr, foun

scaleMin = forceMin ? scaleMin : roundDec(incrRoundUp(scaleMin, foundIncr), numDec);

if (scaleMin === scaleMax)
throw new RangeError("scaleMin cannot be equal to scaleMax");

if (roundDec(scaleMin + foundIncr, numDec) === scaleMin)
Copy link
Copy Markdown
Author

@fastfrwrd fastfrwrd Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only sus thing from the perspective of performance I think. in reality, it's one extra round beyond the rounding the method already does as part of the below for loop, so it seems negligible for the benefit.

throw new RangeError("foundIncr too small for scaleMin");

for (let val = scaleMin; val <= scaleMax; val = roundDec(val + foundIncr, numDec))
splits.push(Object.is(val, -0) ? 0 : val); // coalesces -0

Expand Down Expand Up @@ -841,4 +847,4 @@ export const xScaleOpts = {
export const yScaleOpts = assign({}, xScaleOpts, {
time: false,
ori: 1,
});
});