Fix vi-mode's visual rectangle region #1029
Merged
cxxxr merged 1 commit intolem-project:mainfrom Aug 30, 2023
Merged
Conversation
…top or left-bottom.
cxxxr
reviewed
Aug 30, 2023
Comment on lines
+100
to
+108
| (if (< end-column start-column) | ||
| ;; left-top or left-bottom | ||
| (progn | ||
| (character-offset start 1) | ||
| (incf start-column)) | ||
| ;; right-top or right-bottom | ||
| (progn | ||
| (character-offset end 1) | ||
| (incf end-column))) |
Member
There was a problem hiding this comment.
If possible, cond would be better in these cases.
However, don't use PROGN for an IF clause — use COND, WHEN, or UNLESS.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the vi-mode's visual block region when the cursor moves to right-top or left-bottom.