Conversation
Analagous to emacs dired-jump.
|
Hi, there is already a command on C-x C-j that mimics Dired (open the directory of the current file, place the cursor on the file name).
so it seems this feature is already baked in, but better, because you only call
looks like this is the only addition you want. Why not do it in the existing command? So, I am personally not happy with your PR because I use C-x C-j and you rebind it to another command, this introduces a breaking change. |
|
I've made the change to update find-file-directory only. The directory up command should also select and recenter, but I couldn't make it work easily. |
|
It took an hour, but I now have the directory up command selecting the previous directory name similar to how it was done for find-file-directory. I hope the code isn't too ugly. |
|
nice, this LGTM thanks. (maybe the concatenate and split-sequence could be terser by using You can add cxxxr as a reviewer. |
|
I think it's good. |
This parallels the dired-jump command found in emacs dired-x. Using C-x C-j in a file opens the directory that contains the file in directory-mode. If used in a directory-mode buffer, the it moves up to the parent directory, like ^ in directory-mode.
I have this command hard-wired into my brain, and miss it in lem.
If this is not acceptable, I have an alternate change that exports directory-mode and directory-mode-up-directory so that I can implement it in my init file.