Skip to content

legit: "l l" to show the commits log#1423

Merged
vindarel merged 13 commits intolem-project:mainfrom
vindarel:vindarel/legit-commits-log
Jul 13, 2024
Merged

legit: "l l" to show the commits log#1423
vindarel merged 13 commits intolem-project:mainfrom
vindarel:vindarel/legit-commits-log

Conversation

@vindarel
Copy link
Collaborator

@vindarel vindarel commented Jul 10, 2024

With l l we can see a bigger list of commits (200 by default) on their own buffer/window, and we also see their diff on the right.

Current limitations:

  • we don't have a way to come back to the status buffer, except quitting and re-starting legit-status.
    • actually this UI doesn't have buffers, so we can't just kill a buffer and show the legit-status one. Or it does, but under the hood, we'd need to save and restore the status buffer somehow.
    • (edit) looks like we have g to refresh the view, it brings us back to legit-status. But surely not in an efficient way.
  • no button to show more commits.

edit: => jfaz1 added pagination to see more commits.

cc @jfaz1

@jfaz1
Copy link
Contributor

jfaz1 commented Jul 10, 2024

Nice feature! I'll poke around in it and get back to you in a bit.

@jfaz1
Copy link
Contributor

jfaz1 commented Jul 10, 2024

no button to show more commits

I went ahead and hacked together some pagination so we don't have to fetch a hardcoded amount of commits:

rec.mp4

I pushed it up as a PR on your branch, give it a look when you get a chance 😄

@vindarel vindarel changed the title [WIP] legit: "l l" to show the commits log legit: "l l" to show the commits log Jul 13, 2024
@vindarel vindarel force-pushed the vindarel/legit-commits-log branch from 8c9fcf9 to 99a4763 Compare July 13, 2024 13:18
@vindarel vindarel merged commit 417cc8e into lem-project:main Jul 13, 2024
@vindarel vindarel deleted the vindarel/legit-commits-log branch July 13, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants