Fix a breakage when using the plugin with --source-map on Node 14+.#41
Open
chipx86 wants to merge 1 commit intoless:masterfrom
Open
Fix a breakage when using the plugin with --source-map on Node 14+.#41chipx86 wants to merge 1 commit intoless:masterfrom
chipx86 wants to merge 1 commit intoless:masterfrom
Conversation
A Node.js 14.x added strict type checking when writing files to disk, preventing methods with their own `.toString()` method from being written to disk and generating a `ERR_INVALID_ARG_TYPE` error in the process. This affected using this plugin in combination with `--source-map`. The behavioral change was introduced in nodejs/node#31030 and recently fixed in nodejs/node#34993. That fix was not comprehensive, and did not resolve the issue for the plugin. To avoid this issue for all versions of Node, we no longer assume there will be an implicit call to `SourceMapGenerator.toString()`. Instead, it's now explicitly called when setting the data to write for the source map, fixing source map generation. This was tested on the latest releases of Node 12 through 15.
aminya
approved these changes
Jun 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Node.js 14.x added strict type checking when writing files to disk, preventing methods with their own
.toString()method from being written to disk and generating aERR_INVALID_ARG_TYPEerror in the process. This affected using this plugin in combination with--source-map.The behavioral change was introduced in nodejs/node#31030 and recently fixed in nodejs/node#34993. That fix was not comprehensive, and did not resolve the issue for the plugin.
To avoid this issue for all versions of Node, we no longer assume there will be an implicit call to
SourceMapGenerator.toString(). Instead, it's now explicitly called when setting the data to write for the source map, fixing source map generation.This was tested on the latest releases of Node 12 through 15.