[Dallas] Fix Dallas sensor not being read if optional pin unset#3437
Merged
Conversation
A recent feature addition allowed for an optional separation of RX and TX pin for using Dallas sensors on a Shelly with an isolator board. This still works with using only 1 pin, but not if you set the optional pin to "None". This fixes this inconvenience by just copying the optional pin nr from the standard pin when initializing the sensor. (it is not duplicating it upon saving as that may be confusing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent feature addition allowed for an optional separation of RX and TX pin for using Dallas sensors on a Shelly with an isolator board.
This still works with using only 1 pin, but not if you set the optional pin to "None".
This fixes this inconvenience by just copying the optional pin nr from the standard pin when initializing the sensor. (it is not duplicating it upon saving as that may be confusing)