Update _C001.ino#8
Closed
rmtucker wants to merge 1 commit into
Closed
Conversation
3 tasks
This was referenced Jul 31, 2020
14 tasks
2 tasks
14 tasks
Brommander
added a commit
to Brommander/ESPEasy
that referenced
this pull request
May 13, 2026
letscontrolit#1 Translate all comments to English letscontrolit#2 Use const reference and member initializer list in constructors letscontrolit#3 Explicit {} initialization for global arrays (clarity) letscontrolit#4 Explicit {} initialization for global int variables (clarity) letscontrolit#5 Use auto& dev and DEVICE_TYPE_SERIAL in PLUGIN_DEVICE_ADD letscontrolit#6 Use const variables for serial port/pins from CONFIG letscontrolit#7 Add bounds checks before array index access letscontrolit#8 Replace millis() arithmetic with timePassedSince() letscontrolit#9 Add bounds check at top of D0 read loop letscontrolit#11 Replace C-style casts with static_cast<> letscontrolit#12 Pre-calculate scale factor (powf) in state 32, not per value letscontrolit#13 Declare loop variable outside scope for use in debug log letscontrolit#14 Remove hardcoded serial pins — port now configured via UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I maybe wrong but i think this code is unused?
Just thinking in terms of your quest for space?