Move from env params to cli params only

[europaul]

Adam used to get it's certificates and keys through envs. To unify the UX we switch this mechanism to getting paths to files with certificates and keys through the CLI parameters only.

[giggsoff]

Can you please elaborate why this change required by lf-edge/eden#927 (comment)? Looks like we had 3 options to pass certificates before (path to cert in cli, path to cert in ENV and certificate in ENV), but you remove the last, while still using the first.

[deitch]

I am not sure that it is required. The structure was confusing, though. You provide a file path to a cert, which by default is inside the database path, but is used even if the database is not on disk (e.g. redis or in memory), and then write to that path. I think @europaul's approach makes his straightforward, and like most certificate-based software: provide paths to certs/keys via CLI, software reads it. No confusion about what is provided in alternate approach.

It isn't just the env var. If we had --cert-path and --cert-content, it would be equally confusing.

[europaul]

@giggsoff @deitch you are right, this change is not required. It is more of a clean-up like @deitch explained. Also the envs were potentially overwriting files on disk, which I think is not desirable.

[giggsoff]

Got it, thank you! Please remove the line from readme as well.

[deitch]

Let us know when you are ready to go with this @europaul .

Any other comments @giggsoff ?

[europaul]

Let us know when you are ready to go with this @europaul .

We need to merge lf-edge/eden#927 before we can merge it (unless we don't increment the Adam version, so that Eden ends up using the old version by default).

[deitch]

We need to merge lf-edge/eden#927 before we can merge it (unless we don't increment the Adam version, so that Eden ends up using the old version by default).

OK, so we can wait on that. Also want to see if @giggsoff has anything else here

[deitch]

If @giggsoff approved and I approved and @uncleDecart did it, I see no reason to wait on the merge. :-)