userdata: add tests for write_files in containers#918
userdata: add tests for write_files in containers#918uncleDecart merged 1 commit intolf-edge:masterfrom
Conversation
europaul
force-pushed
the
cloud-config-container-test
branch
from
bfc32e1 to
aaa7a3e
Compare
| eden pod deploy -n eclient --memory=512MB --networks=n1 {{template "eclient_image"}} -p {{$port}}:22 --metadata={{$userdata_file}} | ||
| test eden.app.test -test.v -timewait 20m RUNNING eclient | ||
|
|
||
| exec sleep 3 |
There was a problem hiding this comment.
I would recommend to avoid this sleep and instead make test_injected_file.sh to retry few times (with small sleep between retries) until it succeeds or timeouts. Something like this but with smaller sleep time. Github runners can be slow, meaning that hard-coded sleep time may not be enough (at the same time we do not want to put long unconditional sleeps into tests).
There was a problem hiding this comment.
thanks! I will do it. it also seems to solve the problem of ssh refusing the connection by simply retrying
> exec -t 2m bash test_injected_file.sh "after_restart"
[stdout]
/home/paul/zededa/eden/dist/bin/eden sdn fwd eth0 2223 -- ssh -o ConnectTimeout=10 -o StrictHostKeyChecking=no -i /home/paul/zededa/eden/dist/tests/eclient/image/cert/id_rsa root@FWD_IP -p FWD_PORT grep -q "after_restart" /etc/injected_file.txt
Try 1
time="2023-11-06T14:15:39+01:00" level=fatal msg="command ssh failed: exit status 255"
Try 2
Success
[stderr]
Connection timed out during banner exchange
Connection to 127.0.0.1 port 2223 timed out
Since we added support for write_files in cloud-init configuration for containers - here is a test that will check that functionality, including whether the cloud-init config is reapplied at the containers's reboot Signed-off-by: Paul Gaiduk <paulg@zededa.com>
europaul
force-pushed
the
cloud-config-container-test
branch
from
aaa7a3e to
0ffcc67
Compare
There was a problem hiding this comment.
LGTM! Congratulations @europaul on your first eden test 🎉
|
@uncleDecart seems I come quite late, but nice to check CI. |
|
@giggsoff we will bump EVE version once there will be release including cloud-init changes |
|
Good to know, thank you. But not sure, that it is good idea to merge changes that are expected to fail the tests. If we really need them to be merged, we can point Eden onto non-tagged version (hash) of eve-os here. |
|
@uncleDecart @europaul It seems this is already picked up by EVE and failing at least in this case: https://github.com/lf-edge/eve/actions/runs/6785428539/job/18443723178?pr=3567#step:3:3314 |
|
@milan-zededa you are right, we should not merge tests which are not in EVE version we use for testing. But this tests should not have been picked up, because there is a bug in github-checkout action. I created PR #924 to fix it and if it works, we will merge this to master and backport it to 0.9.2 to avoid this problem. Alternatively, we can put commit hash to EVE version to test in eden. |
|
@milan-zededa thank you for noticing! it's a legitimate bug in my test in https://github.com/lf-edge/eve/actions/runs/6785428539/job/18443723178?pr=3567#step:3:3314. I'm on it! |
4 participants
Since we added support for write_files in cloud-init configuration for containers - here is a test that will check that functionality, including whether the cloud-init config is reapplied at the containers's reboot