Fix cipher context assignment in handlecipherconfig.go

[europaul]

The previous version was always assigning the last cipher context in the slice instead of the one with the correct ID.

[rouming]

Nice catch. Break was missing.

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7c742f2) 19.62% compared to head (b269798) 19.62%.

Files	Patch %	Lines
pkg/pillar/cmd/zedagent/handlecipherconfig.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3675      +/-   ##
==========================================
- Coverage   19.62%   19.62%   -0.01%     
==========================================
  Files         232      232              
  Lines       50746    50746              
==========================================
- Hits         9959     9957       -2     
- Misses      40064    40067       +3     
+ Partials      723      722       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eriknordmark]

Thanks.

Have you seen some failure this would cause, or this is purely from a code review?
If the former we should try to understand where it shoyld be back-ported to lts releases.

[OhmSpectator]

For these cases, I prefer using the index in the loop, breaking on a match and then getting the object by the index. For me, it looks more explicit. But that's also fine.

[europaul]

I would prefer to reference the copy here instead of the actual array element, in case the array might be subject to change.

[europaul]

Thanks.

Have you seen some failure this would cause, or this is purely from a code review? If the former we should try to understand where it shoyld be back-ported to lts releases.

I noticed the bug, while testing the change of signing certificate in the controller -> it introduces more cipher contexts and EVE ends up choosing the wrong one for the decryption.

Since the certificate change in the controller is independent from EVE, this can also affect the older EVE versions.