[16.0-stable] pkg/storage-init: Fix CONFIG partition tmpfs size#5673
Open
rene wants to merge 1 commit intolf-edge:16.0-stablefrom
Open
[16.0-stable] pkg/storage-init: Fix CONFIG partition tmpfs size#5673rene wants to merge 1 commit intolf-edge:16.0-stablefrom
rene wants to merge 1 commit intolf-edge:16.0-stablefrom
Conversation
During storage initialization, the CONFIG partition is mount to a read-only tmpfs to be accessed during runtime. Although the size of CONFIG partition is 1MB, the script is mounting the tmpfs with only 256KB. This leads to a subtle buggy behavior: depending on how much storage is used, some data will not be accessible on the tmpfs. For instance, if we just create some files and consume some storage on the physical CONFIG partition, during run-time we might see files, like /config/server completely empty, even though the contents are correct on the disk. This commit fixes this bug by mounting the tmpfs with the same size of the physical partition (1MB). Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br> (cherry picked from commit 0c40792)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5668
How to test and validate this PR
Run EVE and check if
/configis mount with the correct size (1MB):Changelog notes
Increase the CONFIG partition tmpfs mount size from 256KB to 1MB to match the physical partition and prevent data truncation.
Checklist
check them.