eve-k: fix pillar 'make test' for macOS M-series (ZARCH=arm64 HV=k)#5846
Open
andrewd-zededa wants to merge 1 commit intolf-edge:masterfrom
Open
eve-k: fix pillar 'make test' for macOS M-series (ZARCH=arm64 HV=k)#5846andrewd-zededa wants to merge 1 commit intolf-edge:masterfrom
andrewd-zededa wants to merge 1 commit intolf-edge:masterfrom
Conversation
Contributor
Author
|
The Darwin bypass in build-docker-test-dependencies is not the best, working to remove it. |
andrewd-zededa
force-pushed
the
eve-k-macos-pillar-make-test
branch
3 times, most recently
from
eac8749 to
f2f95cc
Compare
Contributor
Author
|
Ok, Darwin bypass removed, top level makefile target comment updated to show macOS make motivated issue |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5846 +/- ##
==========================================
- Coverage 21.70% 20.93% -0.77%
==========================================
Files 465 496 +31
Lines 84035 91400 +7365
==========================================
+ Hits 18237 19134 +897
- Misses 64265 70537 +6272
- Partials 1533 1729 +196 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrewd-zededa
force-pushed
the
eve-k-macos-pillar-make-test
branch
from
f2f95cc to
5ec76aa
Compare
Contributor
Author
|
Rebased on master |
rene
reviewed
Apr 23, 2026
andrewd-zededa
force-pushed
the
eve-k-macos-pillar-make-test
branch
from
5ec76aa to
3bef59f
Compare
andrewd-zededa
force-pushed
the
eve-k-macos-pillar-make-test
branch
from
3bef59f to
5c34c87
Compare
Contributor
Author
|
rebased on recent master |
andrewd-zededa
force-pushed
the
eve-k-macos-pillar-make-test
branch
from
5c34c87 to
c463c8c
Compare
andrewd-zededa
changed the title
7 tasks
Contributor
Author
|
@rene I've scaled back the scope of this PR to only resolve the macOS M-series non-cross compile ZARCH=arm64 HV=k go tests. |
GNU Make 3.81 (macOS) selects pattern rules by first-match, so pillar-% wins over %-cache-export-docker-load for the target pillar-cache-export- docker-load. Add an explicit rule to the top-level Makefile that beats all pattern rules in every Make version. Pass --build-yml to linuxkit in pkg/pillar/Makefile so HV=k selects build-k.yml instead of the default build.yml, and fix the test tag from kubevirt to k. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Andrew Durbin <andrewd@zededa.com>
andrewd-zededa
force-pushed
the
eve-k-macos-pillar-make-test
branch
from
c463c8c to
337549d
Compare
Contributor
Author
|
rebased on latest master |
rene
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GNU Make 3.81 (macOS) selects pattern rules by first-match, so pillar-%
wins over %-cache-export-docker-load for the target pillar-cache-export-
docker-load. Add an explicit rule to the top-level Makefile that beats
all pattern rules in every Make version.
Pass --build-yml to linuxkit in pkg/pillar/Makefile so HV=k selects
build-k.yml instead of the default build.yml, and fix the test tag
from kubevirt to k.
PR dependencies
None
How to test and validate this PR
make ZARCH=arm64 HV=k testDONE 553 tests, 15 skipped in 374.852sChangelog notes
Fix pillar make test for m series Mac, HV=k ZARCH=arm64
PR Backports
Checklist
And the last but not least:
check them.
Please, check the boxes above after submitting the PR in interactive mode.