Skip to content

pkg/eve: Fix image sizes for evaluation variant#5932

Open
rene wants to merge 1 commit intolf-edge:masterfrom
rene:fix-eval-eve-img
Open

pkg/eve: Fix image sizes for evaluation variant#5932
rene wants to merge 1 commit intolf-edge:masterfrom
rene:fix-eval-eve-img

Conversation

@rene
Copy link
Copy Markdown
Contributor

@rene rene commented May 9, 2026

Description

The installer-raw image for evaluation variant doesn't fit on 4GB anymore. This commit adjusts the size.

How to test and validate this PR

Build evaluation eve and generate the installer image.

make PLATFORM=evaluation eve
docker --rm <eve_image> installer_raw > eve-installer.raw

Changelog notes

Fix evaluation eve installer image generation through docker image.

PR Backports

This is just on master. No backport needed.

Checklist

  • I've provided a proper description
  • I've added the proper documentation
  • I've tested my PR on amd64 device
  • I've tested my PR on arm64 device
  • I've written the test verification instructions
  • I've set the proper labels to this PR
  • I've checked the boxes above, or I've provided a good reason why I didn't
    check them.

Please, check the boxes above after submitting the PR in interactive mode.

The installer-raw image for evaluation variant doesn't fit on 4GB
anymore. This commit adjusts the size.

Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
@rene rene requested a review from eriknordmark as a code owner May 9, 2026 08:10
@rene rene added the bug Something isn't working label May 9, 2026
Copy link
Copy Markdown
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.15%. Comparing base (1fd59f8) to head (c9bc698).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5932      +/-   ##
==========================================
+ Coverage   21.72%   22.15%   +0.43%     
==========================================
  Files         465      475      +10     
  Lines       84086    85784    +1698     
==========================================
+ Hits        18264    19003     +739     
- Misses      64281    65058     +777     
- Partials     1541     1723     +182     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eriknordmark
Copy link
Copy Markdown
Contributor

@rene When using EDEN I also found that this gets in the way for future tests (since they can't create a usable IMGB partition and use it for eveimage update):
master/eve/pkg/eve/runme.sh:DEFAULT_LIVE_IMG_SIZE=8192

There are other LIVE sizes in runme.sh and they should be at least 16k to leave some space for apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants