Fix file structure for future networks option#2070
Conversation
0d6a4d2 to
0e64366
Compare
|
Hi @petervdonovan. I'm having the problem in this issue #1838. Do you think it's just failing or will there be any other reasons? I totally have no idea why this test is failing. But I'm starting to doubt myself because even though I rerun those tests it still doesn't work. I'd like some help for this. |
|
The diff in the reactor-c submodule in this PR is larger than the diff in the linked reactor-c PR: lf-lang/reactor-c@5bbdefd...eed0374 If there is a segfault still then maybe it would be good to do whatever rebasing/submodule updating is necessary to isolate the changes that are relevant to this PR. IIUC this and the linked PR look like they should only introduce organizational changes and not significant semantic changes to the semantics of the C code in the C runtime. |
8738b38 to
da8022f
Compare
|
@petervdonovan Thanks for your tips. I did the rebasing but it still gets this error. I tried on local environments, but it passes all the And I kind of didn't understand what you told me about the |
…into network-structure
|
Oh, I'm getting these failures now on local. I'll take a look at it. |
|
It looks like the reason why there are failures in this branch but not in |
|
Still getting this strange segfault. |
|
Yes, I saw. |
networks optionnetworks option
|
@lhstrh Would you please review this? |
|
@lhstrh Looks like I'm not authorized to merge this. Would you please merge it? |
This should be merged with lf-lang/reactor-c#292. Details are inside that PR.
This is a minor change for the code generator.