Fix wrong library filename (in Windows) #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why we create both static and shared type of library? Signed-off-by: Mikko Johannes Koivunalho <[email protected]>
Change from checkStatic to checkDynamic. Was erroneously "checkStatic". Signed-off-by: Mikko Johannes Koivunalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To maintain compatibility with the Autotools installation we specifically create both shared and static libraries as that is what Autotools script has been doing. Normally CMake would create the system's native default library type.
In Windows we shall create two library files: "check.lib" and "checkDynamic.lib".
This separation is necessary. In Unix/Linux the files would be libcheck.a and libcheck.so, only separated by the filename suffix. But in Windows all library files end with ".lib", both static and dynamic.