Skip to content

Conversation

@mikkoi
Copy link
Contributor

@mikkoi mikkoi commented Oct 25, 2019

Rename CMake project from 'check' to 'Check'

Check should be written with a capital letter.
In a CMake script this makes a difference as
`find_package(Check)` should work, not `find_package(check)`.

This change does not alter how Check is installed.
Maintaining compatibility with GNU Autotools installation
is mandatory.

Check should be written with a capital letter.
In a CMake script this makes a difference as
`find_package(Check)` should work, not `find_package(check)`.

This change does not alter how Check is installed.
Maintaining compatibility with GNU Autotools installation
is mandatory.

Signed-off-by: Mikko Johannes Koivunalho <[email protected]>
Signed-off-by: Mikko Johannes Koivunalho <[email protected]>
@brarcher
Copy link
Contributor

If I understand the change, it will not affect CMake users' projects if they upgrade Check to this change, is that right? For example, could updating Check result in it no longer being found for a CMake project in Windows due to the name change?

@mikkoi
Copy link
Contributor Author

mikkoi commented Oct 28, 2019

This change will not alter the behaviour how CMake projects are currently discovering Check. Since we have not supported CMake's own discovery methods before, including Cmake Package Registry, current users are using the Find*.cmake file method, as described in our documentation (:doc/example/cmake/FindCheck.cmake). This Find file uses the pkg-config program to find Check, and pkg-config only relies on library file names.

@brarcher brarcher merged commit c5d9592 into libcheck:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants