Adding Pre-Push Callback Support

[whoisj]

added PushUpdate class, updated GitPushUpdate struct

completed plumbing from libgit2 => API layer

added a positive test, failed to get a negative test to work correctly

[whoisj]

Currently return anything except 0 from the hook will cause an exception to be thrown in the managed layer. I'm not sure this is what we want to be seeing. Perhaps it is. Having a hook block a push for any reason might not be considered exceptional. I'm looking for feedback on this.

Once we have the answer to the above, I'll complete the negative test case to insure than returning a failing value blocks the upload portion of the push.

[jamill]

Negotiation is misspelled 😄

[whoisj]

As a senior member of the American Bad Spellers Society Id like to thank you for recognition of my (in)abilities. 😆

[nulltoken]

@whoisj FWIW, most of the spell checking tools delegate the hard work to @jamill

[jamill]

Having a hook block a push for any reason might not be considered exceptional. I'm looking for feedback on this.

I think it is reasonable for an exception generated in the push handler to block the push. If someone is relying on the hook to approve changes, then I would like for an error to block the push.

[jamill]

@whoisj Thanks for the PR 🎆 ! I think this will be nice addition. I had some feedback and weighed in on your question.

[whoisj]

I believe the PR is all fixed up based on the feedback so far.

I found a handy Assert.Throws<UserCancelledException> utility function that cleared the way for a successful negative unit test.

[whoisj]

darn github close and comment button. It's larger than the comment button and there's no confirmation dialog. I think I've close and reopened every PR I've started accidentally at this point 😖

[whoisj]

I believe everything is hunky-dory

/CC @nulltoken @jamill

[nulltoken]

received?

[whoisj]

@nulltoken spelling errors corrected in the test code 😜

[nulltoken]

🆒 Before we merge this in, could you please sprinkle a bit of your squashing magic on this PR?

[whoisj]

🆒 Before we merge this in, could you please sprinkle a bit of your squashing magic on this PR?

Done sir, all squashed up. 😇

[nulltoken]

💥 ‼️