Fix Move higher level Index related ops to IRepository #822 #830
Conversation
JPaulDuncan
changed the title
|
Not sure why this test fails... [Fact]
public void CanRemoveAFolderThroughUsageOfPathspecsForNewlyAddedFiles()
{
string path = CloneStandardTestRepo();
using (var repo = new Repository(path))
{
repo.Stage(Touch(repo.Info.WorkingDirectory, "2/subdir1/3.txt", "too"));
repo.Stage(Touch(repo.Info.WorkingDirectory, "2/subdir2/4.txt", "tree"));
repo.Stage(Touch(repo.Info.WorkingDirectory, "2/5.txt", "for"));
repo.Stage(Touch(repo.Info.WorkingDirectory, "2/6.txt", "fyve"));
int count = repo.Index.Count;
Assert.True(Directory.Exists(Path.Combine(repo.Info.WorkingDirectory, "2")));
repo.Remove("2", false);
Assert.Equal(count - 5, repo.Index.Count);
}
} |
|
/cc @nulltoken |
@JPaulDuncan I'm taking a look. |
|
Could you please remove the methods with nullable parameters from |
| @@ -104,16 +104,15 @@ public void CanRemoveAFolderThroughUsageOfPathspecsForNewlyAddedFiles() | |||
| string path = CloneStandardTestRepo(); | |||
| using (var repo = new Repository(path)) | |||
| { | |||
| repo.Index.Stage(Touch(repo.Info.WorkingDirectory, "2/subdir1/2.txt", "whone")); | |||
There was a problem hiding this comment.
This line hasn't been ported (only removed). This is why the test fails.
| @@ -134,11 +134,10 @@ IEnumerator IEnumerable.GetEnumerator() | |||
| /// </summary> | |||
| /// <param name="path">The path of the file within the working directory.</param> | |||
| /// <param name="stageOptions">If set, determines how paths will be staged.</param> | |||
| [Obsolete("This method will be removed in the next release. Use Repository.Stage instead.")] | |||
There was a problem hiding this comment.
Please add parentheses after the method name (ie. ...Use Repository.Stage() instead.)
|
@JPaulDuncan Once you've dealt with the nitpicks above, please squash your commits altogether into one, then rebase your branch onto vNext so we can get it merged. If you're not sure how to do this, let us know, we'll guide you through the process. FWIW, I don't get automatic notifications when you only push commits. Please add a comment when the code is ready to review (otherwise some days may pass before I happen to notice the PR has been updated). |
|
Superseded by #851 Cheers! |
2 participants
No description provided.