Update to LibGDX 1.14.0 and add PointMapObject to tiled shape extension#509
Open
Quillraven wants to merge 8 commits intolibktx:developfrom
Open
Update to LibGDX 1.14.0 and add PointMapObject to tiled shape extension#509Quillraven wants to merge 8 commits intolibktx:developfrom
Quillraven wants to merge 8 commits intolibktx:developfrom
Conversation
# Conflicts: # CHANGELOG.md # buildSrc/src/main/kotlin/ktx/Versions.kt # tiled/src/test/kotlin/ktx/tiled/MapObjectTest.kt
Contributor
Author
|
yes, now it only shows the relevant changes. looks better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With LibGDX 1.14.0 we also have a new PointMapObject which I added to the shape extension function. It also contains some breaking changes regarding the different tiled map loader parameter classes because they were all empty and redundant. So it got reduced to a single "base" parameter class.
I noticed that VisUI tests are failing because the getText method that returns a StringBuilder doesn't exist. StringBuilder got replaced with CharArray from what I can tell. However, Vis-UI hasn't rolled out the new version yet that supports LibGDX 1.14.0. I see there are commits that fix the mentioned issue but the version was not released yet.
Therefore, I added @ignored to the failing tests for now.
sorry for the duplicate, I wasn't on the latest develop. I hope this is fixed now. The other PR got automatically closed it seems due to the "force merge" or whatever it is called.