Skip to content

fix(keystore): use new batch after commit#1154

Merged
guillaumemichel merged 1 commit intomasterfrom
fix/keystore-batch
Sep 23, 2025
Merged

fix(keystore): use new batch after commit#1154
guillaumemichel merged 1 commit intomasterfrom
fix/keystore-batch

Conversation

@guillaumemichel
Copy link
Collaborator

Previously, we recycled the old datastore batch after it was committed, resulting in panic: pebble: batch already committing.

We now create a new batch after committing the previous one.

@guillaumemichel guillaumemichel requested a review from a team as a code owner September 23, 2025 09:39
@guillaumemichel guillaumemichel merged commit 6f794d8 into master Sep 23, 2025
9 checks passed
@guillaumemichel guillaumemichel deleted the fix/keystore-batch branch September 23, 2025 14:33
@lidel lidel mentioned this pull request Sep 23, 2025
49 tasks
@gyurmogyuri
Copy link

gyurmogyuri commented Oct 7, 2025

I have same error on arm64 Linux [Release 0.38]. What can I do? Until the next release, can't use the pebble database? It's very crappy if that's the case.

@guillaumemichel
Copy link
Collaborator Author

@gyurmogyuri This PR fixes the panic in the provider/keystore.

The fix for kubo is ipfs/kubo#11011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants