Skip to content

[fix]: resolve npm vulnerabilities with dompurify - #1392

Merged
gabriela-almeida-ctw merged 1 commit into
developfrom
bugfix/resolve-npm-vulnerabilities
Nov 2, 2026
Merged

gabriela-almeida-ctw merged 1 commit into
developfrom
bugfix/resolve-npm-vulnerabilities

Conversation

@gabriela-almeida-ctw

@gabriela-almeida-ctw gabriela-almeida-ctw commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

User-Facing Changes

Description

[fix]: resolve npm vulnerabilities with dompurify

Checklist

  • The web version was tested and it is running ok
  • The desktop version was tested and it is running ok
  • This change is covered by unit tests
  • Files constants.ts, types.ts and *.style.ts have been checked and relevant code snippets have been relocated

Summary by CodeRabbit

  • Chores
    • Updated the DOMPurify dependency to version 3.4.17.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between f979eb8 and d5f4c40.

Files ignored due to path filters: 1
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock, !yarn.lock
Files selected for processing: 2
  • package.json
  • packages/suite-base/package.json

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

The root DOMPurify resolution and the packages/suite-base dependency were updated to version 3.4.17.

Changes

DOMPurify version update

Layer / File(s) Summary
Update DOMPurify versions
package.json, packages/suite-base/package.json
The root resolution changed from 3.4.11 to 3.4.17. The suite-base dependency changed from 3.4.16 to 3.4.17.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Suggested labels: dependencies

Suggested reviewers: ctw-joao-luis

Merge Risk: Minimal · up to d5f4c

No blocking issue is established for the aligned DOMPurify update. Merge after normal installation, build, and test checks pass.

Pre-merge checks: Passed 4 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Description check Inconclusive The description includes all required headings and the checklist, but the User-Facing Changes section is empty and the Description section only repeats the title. The implementation details and test s… Add a concise summary of the DOMPurIFY dependency upgrades and their user impact. State whether tests and web or desktop validation were completed, and check the applicable checklist items.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the main change: upgrading DOMPurify to address npm vulnerabilities.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Full details: Description check

Explanation

The description includes all required headings and the checklist, but the User-Facing Changes section is empty and the Description section only repeats the title. The implementation details and test status are unclear.

Resolution

Add a concise summary of the DOMPurIFY dependency upgrades and their user impact. State whether tests and web or desktop validation were completed, and check the applicable checklist items.

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2026

Copy link
Copy Markdown

@gabriela-almeida-ctw
gabriela-almeida-ctw merged commit c852328 into develop Nov 2, 2026
21 checks passed
@gabriela-almeida-ctw
gabriela-almeida-ctw deleted the bugfix/resolve-npm-vulnerabilities branch November 2, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants