Repository navigation
Conversation
Signed-off-by: Taeseung Sohn <paulsohnjp@gmail.com>
Contributor
|
Hey @paulsohn, first of all thanks for the PR! Cheers, |
rodrigo-p-rodrigues
approved these changes
Dec 5, 2025
Contributor
There was a problem hiding this comment.
These changes are ok.
Make sure to merge the develop branch, and fix the branch name so that the CI doesn't fail. We've also updated the action rules so that SonarCloud skips if the change comes from a fork.
NOTE: They depend on the version of @foxglove/ws-protocol (0.8.0.). We've since updated its version in the develop branch as well, so with both, it works.
1 of 4 tasks
ctw-joao-luis
pushed a commit
that referenced
this pull request
Dec 9, 2025
… ) (#819) ## User-Facing Changes Add support for `foxglove.sdk.v1` WebSocket subprotocols. As stated in [the current Foxglove developer's stance](https://github.com/orgs/foxglove/discussions/1131), currently this subprotocol is identical to `foxglove.websocket.v1`, so supporting subprotocol is just adding the new subprotocol name alongside the older one, and the end user need not to distinghish the Foxglove bridge 3.2.1 and 0.8.x. Resolving #547 #604 #750 . Duplicate of #772 (closed and reopened due to branch name restriction) ## Description <!-- link relevant GitHub issues --> <!-- add `docs` label if this PR requires documentation updates --> <!-- add relevant metric tracking for experimental / new features --> ## Checklist - [x] The web version was tested and it is running ok - [ ] The desktop version was tested and it is running ok - [ ] This change is covered by unit tests - [ ] Files constants.ts, types.ts and *.style.ts have been checked and relevant code snippets have been relocated Signed-off-by: Taeseung Sohn <paulsohnjp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
Description
Talking about #547 , #604 and #750 , why is the solution for Foxglove bridge incompatibility always 'downgrade to 0.8.5'?
foxglove.sdk.v1is, at least for now, completely identical protocol tofoxglove.websocket.v1except for the name (which is not guaranteed for the long term though; this is their official stance), so supporting the new bridge 3.2.1 is just as easy as adding a string into the array. Even Flora did that.AFAIR, one of the many reasons why ws-protocol is deprecated in the Foxglove side is that the old bridge depends on websocketpp, a C++ websocket implementation which has been, de facto stopped maintaining since about 5 years ago. If the team is really working on drop-in replacement of ws-protocol, I would expect that would involve implementing websocket from scratch as well.
Checklist