Skip to content

fix(responses): route local compaction checkpoints - #8119

Merged
lidge-jun merged 3 commits into
devfrom
fix/8089-local-compaction
Nov 3, 2026
Merged

lidge-jun merged 3 commits into
devfrom
fix/8089-local-compaction

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

Verification

  • bun test tests/responses/local-checkpoint-routing.test.ts — with the routing fix reverted to the dev source: 1 passed, 5 failed, including the WebSocket and target-model assertions (independently reproduced in review); with the fix: 6 passed, 0 failed.
  • bun test tests/responses/responses-compaction-override.test.ts tests/responses/compaction-history-framing.test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.ts — 115 passed, 0 failed.
  • bun run typecheck — passed.
  • bun run privacy:scan — passed.
  • bun run structure:check — passed.
  • cd docs-site && bun install --frozen-lockfile && bun run build — passed (existing syntax-highlighting warnings).
  • bun run test:changed — interrupted after several minutes under host contention; no result was emitted. This PR remains draft pending broader validation.
  • NOT RUN: full suite left to CI due to host contention.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between f7c2d32 and c57848d.

Files selected for processing: 7
  • docs-site/src/content/docs/reference/configuration/server.md
  • scripts/test-layout/layout.json
  • src/responses/compaction-history-framing.ts
  • src/server/responses/compaction-routing.ts
  • structure/transports/responses-failover.md
  • tests/fixtures/test-layout-expected.json
  • tests/responses/local-checkpoint-routing.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Nov 3, 2026
@lidge-jun
lidge-jun marked this pull request as ready for review November 3, 2026 07:11
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner November 3, 2026 07:11
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T07:14:22.661810Z c57848d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer integration into dev (account lidge-jun) at head c57848de7d57d343af1c13c2a6bc220fe04637b1.

  • The branch merges current dev (f7c2d3211); exact-head required CI passed: ci, enforce-target, hygiene, test shards 1/4–4/4.
  • Independent code review (gpt-6.1-terra, high) passed on this change.
  • No unresolved review threads or changes-requested reviews.

Resolves #8089.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant