Update bLIP 32 to point to BOLT 12 for name/domain inclusion#48
Merged
t-bast merged 1 commit intolightning:masterfrom Dec 3, 2024
Merged
Conversation
Placing BIP 353 name/domain entries in BOLT 12 `invoice_request`s ended up being done in BOLT 12 (in lightning/bolts#1180) rather than a bLIP, so we should make reference to that.
|
lightning/bolts#1180 has not been merged yet, so confused about your use of past tense? Seems like this should not get merged unless lightning/bolts#1180 does. |
Contributor
Author
|
Fair, this should wait on the BOLT PR. |
Contributor
|
LGTM once lightning/bolts#1180 has been merged. |
Contributor
|
lightning/bolts#1180 has been merged, so we can now land this update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Placing BIP 353 name/domain entries in BOLT 12
invoice_requests ended up being done in BOLT 12 (inlightning/bolts#1180) rather than a bLIP, so we should make reference to that.