Skip to content

Migrate imagine.xml config to php format#1640

Merged
dbu merged 1 commit intoliip:2.xfrom
dmaicher:xml_to_php
Oct 22, 2025
Merged

Migrate imagine.xml config to php format#1640
dbu merged 1 commit intoliip:2.xfrom
dmaicher:xml_to_php

Conversation

@dmaicher
Copy link
Contributor

Q A
Branch? 2.x
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -
License MIT
Doc

Part of #1634

This migrates the big imagine.xml config file to php format.

I used this tool, added imports for classes + copied over comments from the xml file.

@coveralls
Copy link

coveralls commented Oct 21, 2025

Coverage Status

coverage: 81.61%. remained the same
when pulling b111bda on dmaicher:xml_to_php
into 1b43e2e on liip:2.x.

Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad to hear that there is a tool for this, would be quite the chore to completely do by hand.

thanks a lot for the effort, looks good!

@dbu dbu merged commit 6f1e79f into liip:2.x Oct 22, 2025
30 checks passed
@dmaicher dmaicher deleted the xml_to_php branch October 22, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants